-
Notifications
You must be signed in to change notification settings - Fork 139
feat: solu
- part 1
#4154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/main_solu
Are you sure you want to change the base?
feat: solu
- part 1
#4154
Conversation
All Contributor License Agreement (CLA) signatures have been captured successfully. Thanks for contributing! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/main_solu #4154 +/- ##
=================================================
Coverage ? 91.28%
=================================================
Files ? 198
Lines ? 15781
Branches ? 0
=================================================
Hits ? 14406
Misses ? 1375
Partials ? 0 🚀 New features to boost your workflow:
|
This PR is ready for review @germa89 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Few minor comments.
The order of specifying the gap nodes is important; that is, a gap condition connecting two nodes | ||
will act differently depending upon which node is specified first on the :ref:`gp` command. For | ||
example, for Node 1 at ``X`` = 0.0, Node 2 at _nolinebreak ? ``X`` = | ||
0.1 /_nolinebreak ?, and the gap defined from Node 1 to 2, a displacement of Node 1 greater than |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_nolinebreak
? I never saw that. Please, confirm this is correct.
.. warning:: | ||
|
||
This command is archived in the latest version of the software. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This on me, but not sure if we should do something with archived commands....
val1 : str | ||
The description of the argument is missing in the Python function. Please, refer to the `command | ||
documentation | ||
<https://ansyshelp.ansys.com/Views/Secured/corp/v232/en//ans_cmd/Hlp_C_AMSTEP.html>`_ for | ||
further information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this expected?
Description
This PR follows the PyConverter-XML2Py integration plan to automate the PyMAPDL_commands documentation.
The changes have been generated using pyconverter-xml2py and more specifically mapdl-cmd-conv.
This PR focus on the first part of the
solu
submodule integration.You can check the mapdl-cmd-conv documentation to have a look at the output of each methods.
Pinging @ansys/pymapdl-developers for visibility. Feel free to provide any feedback on the way the docstrings and the source code generation are handled.
Issue linked
This PR is meant to be merged within the feat/main_solu branch. The latter will gather all the parts of the submodule prior to be merged to the main branch.
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)